Change
Unlabeled topics again
Issue description
The initial solution for this caused a number of issues that a topic is not listed where it is expected, e.g. in the index or in a select box in the service form. Latter is the case when the extent of a topic argument is a file topic type. These usually come without name or label rule. This has to be given more thought as the original behavior – using the topic id as a backup – seems to have been a good one.
Developer comments
Instead of requiring a label rule returning the id for an otherwise unlabelled topic type, it would be better to require a label rule returning false if the topic is unlabelled or to use a flag on the topic type.
The biggest chunk of unnecessary labels is created by row adjuncts. Therefore do not label these unless there is a label rule defined. Also a name should not be used in this case. In the index the sections of these topic types should be closed always. A click on the section header should do nothing. The arrow to the right should be diabled. There is not a single service which takes such topic types in any systems until today, so it is also no problem that they cannot be displayed in select boxes. In any case the administrator can always define a label rule.
This caused a subtle change in the behavior. It surfaces in the regression test of [11658, this issue]. Before this change: topics with neither label rule nor name did not have an entry in the labels table – they were "unlabeled". So they were not found in the index or the search. With this change they will at least be present in the index with their id.
|
Work sessions4
Start |
2024-03-29T08:53:37
|
End |
2024-03-29T11:31:29
|
Participant |
Robert Cerny
|
Start |
2024-03-29T15:20:05
|
End |
2024-03-29T17:59:14
|
Participant |
Robert Cerny
|
Start |
2024-03-30T07:14:43
|
End |
2024-03-30T09:21:31
|
Participant |
Robert Cerny
|
Start |
2024-04-01T09:24:06
|
End |
2024-04-01T12:03:00
|
Participant |
Robert Cerny
|
|
We are sorry
This page cannot be displayed in your browser. Use Firefox, Opera, Safari, or Chrome instead.